Recent changes to feature-requests

#26 pcap or verbose log replay tool

Alexander Amelkin — Sat, 31 Mar 2018 19:04:01 -0000

status: open --> closed

#3 IPMI_AUTH_RAKP_HMAC_MD5 support in lanplus

Zdenek Styblik — Thu, 19 May 2016 20:02:35 -0000

assigned_to: Zdenek Styblik
Group: --> version-cvs

#3 IPMI_AUTH_RAKP_HMAC_MD5 support in lanplus

Zdenek Styblik — Thu, 19 May 2016 20:02:13 -0000

This is linked to https://sourceforge.net/p/ipmitool/bugs/441/ and https://sourceforge.net/p/ipmitool/bugs/141/

#60 Use meaningful Generator ID for "ipmitool sel add"

Martin Wilck — Tue, 08 Dec 2015 10:49:24 -0000

Suggested patch.

Use meaningful Generator ID for "ipmitool sel add"

Martin Wilck — Tue, 08 Dec 2015 10:43:13 -0000

"ipmitool sel add" always sets the Generator ID field of the generated SEL entry to 0x0000.

Looking at the IPMI spec v2, §13.2, this is questionable. The value 0 would be read as a HW-generated event from IPMB with slave address 0, which is the broadcast or ["general call"]http://www.i2c-bus.org/addressing/ address.

The spec says that the Generator ID should be "Software ID if event was generated from system software", and goes on to say that bit 0 should be set to 1 and bit 1-7 should be set to the Software ID for software-generated events. SEL entries generated by ipmitool will usually be software-generated.

Out of the SWIDs defined in §5.5 of the IPMI spec, "System management Software" or "OEM" would match ipmitool's use best, thus it would make sense to set the generator ID field to 0x0041 or 0x0061.

I request to change the default Generator ID used by ipmitool, or make it user-configurable.

#58 Support for new Communication Interface (USB Medium)

Zdenek Styblik — Tue, 08 Sep 2015 04:51:21 -0000

Hi David,

I'm sorry, but I completely misunderstood your reply. Also, I can see we were talking about different things. I was talking about fix and you about workaround. The problem, unterminated string, is still there, however I can see now it can't be fixed. I'll proceed with code formatting then and commit into git once done.

#58 Support for new Communication Interface (USB Medium)

Zdenek Styblik — Tue, 08 Sep 2015 04:41:53 -0000

#58 Support for new Communication Interface (USB Medium)

David Wise — Thu, 27 Aug 2015 20:21:53 -0000

Zdenek,

The InitCmdHeader function is appending the BEGIN_SIG string to the beginning of the command. So I don't think increaing the BEGIN_SIG_LEN is possible. Yes this interface has been in use in our existing code for some time and is also used by some of our customers.

Is Coverity still throwing error after changing the strncpy to memcpy?

Thanks,
David Wise

#58 Support for new Communication Interface (USB Medium)

Zdenek Styblik — Tue, 25 Aug 2015 04:38:29 -0000

Hello David,

it's ok. I'm just "checking pulse". I'm sorry to hear BEGIN_SIG thing is being PITA. I'm thinking this and that, but I can't figure out way how to cheat this. It's understandable that changing size of(alignment of attributes/items in) structure breaks the communication. I presume this interface is already out in the wild, correct?

#58 Support for new Communication Interface (USB Medium)

David Wise — Mon, 24 Aug 2015 21:12:19 -0000

Zdenek,

Sorry I have been swamped with other work and I have not had a chance to come back to this. I tried increasing the size of BEGIN_SIG_LEN to accomodate the NULL terminating character, and this caused problems communicating over the USB interface.

Since the BEGIN_SIG is getting added to the beginning of the command string I instead used a memcpy in place of strncpy.

Thanks,
David Wise