[patch] Fix build with GCC-15

2025-09-13T15:26:48.613000Z

This patch fix build with GCC-15.

Best Regards,
mt

[patch] Fix gcc warning of implicit-declaration to memcpy function

2021-06-04T22:57:20.154000Z

Patch to fix gcc warning of implicit-declaration to memcpy function in the file src/image.c

[patch] Fix typos in ziproxylogtool

2021-06-04T22:52:27.294000Z

Patch to fix some typos in ziproxylogtool.

Bug in PNG compression ?

2012-11-20T10:02:51Z

Hi,

on my ubuntu-system running ziproxy 3.2.1 I detected the strange effect, that only small PNGs are compressed, larger images not.

Below a debug output for both an unsuccessful and a successful recompress, done within a few minutes on the same system.

Any ideas ?

Cheers,

Reiner

-------------------------Unsuccessful
[29460] URL - http://tippspiel.spiegel.de/img/prize/product/spon/kameha_grand_gross.png
[29460] Headers from client:
[29460] Accept: */*
[29460] Accept-Language: de-DE,en-US;q=0.5
[29460] User-Agent: Mozilla/4.0 (compatible; MSIE 7.0; Windows NT 6.1; WOW64; Trident/5.0; .NET4.0C)
[29460] Accept-Encoding: gzip, deflate
[29460] Host: tippspiel.spiegel.de
[29460] Pragma: no-cache
[29460] Cookie: spVcData2=11-21%3B21-30; __utma=159392383.453791998.1351331618.1353014537.1353073350.12; __utmz=159392383.1351331618.1.1.utmcsr=(direct)|utmccn=(direct)|utmcmd=(none); spTopPosterHide=true; __utmc=159392383; PHPSESSID=eueb0n6iin7aldpsf56t1nqu35hhhlua
[29460] getting, parsing headers took 116 us.
[29460] Method = GET Protocol = HTTP/1.0
[29460] Headers sent to server:
[29460] GET /img/prize/product/spon/kameha_grand_gross.png HTTP/1.0
[29460] Accept: */*
[29460] Accept-Language: de-DE,en-US;q=0.5
[29460] User-Agent: Mozilla/4.0 (compatible; MSIE 7.0; Windows NT 6.1; WOW64; Trident/5.0; .NET4.0C)
[29460] Host: tippspiel.spiegel.de
[29460] Pragma: no-cache
[29460] Cookie: spVcData2=11-21%3B21-30; __utma=159392383.453791998.1351331618.1353014537.1353073350.12; __utmz=159392383.1351331618.1.1.utmcsr=(direct)|utmccn=(direct)|utmcmd=(none); spTopPosterHide=true; __utmc=159392383; PHPSESSID=eueb0n6iin7aldpsf56t1nqu35hhhlua
[29460] Accept-Encoding: gzip
[29460] Connection: close
[29460] Connecting, forwarding headers took 15696 us.
[29460] In Headers:
[29460] HTTP/1.1 200 OK
[29460] Date: Fri, 16 Nov 2012 14:29:14 GMT
[29460] Server: Apache/2.2.17 (Linux/SUSE)
[29460] Last-Modified: Wed, 01 Aug 2012 14:01:30 GMT
[29460] ETag: "482dc0-4850b-4c634bb5dcf85"
[29460] Accept-Ranges: bytes
[29460] Content-Length: 296203
[29460] Connection: close
[29460] Content-Type: image/png
[29460] Image = 1, Chunked = 0
[29460] WillGZip = 1, Compress = 0, DoPreDecompress = 0
[29460] Trying to load the whole data into memory
[29460] Ok, whole data loaded into memory
[29460] Starting image decompression...
[29460] Image parms (non-palette) -- w: 500, h: 306, bpp: 4
[29460] Deciding image compression strategy...
[29460] Strategy defined. Continuing...
[29460] Attempting PNG compression...
[29460] Compression return codes -- JP2K:33 JPEG:33 PNG:65539
[29460] Image modification/compression took 627335 us.
[29460] and returned 0.
[29460] Forwarding header and modified content.
[29460] Out Headers:
[29460] HTTP/1.1 200 OK
[29460] Date: Fri, 16 Nov 2012 14:29:14 GMT
[29460] Server: Apache/2.2.17 (Linux/SUSE)
[29460] Last-Modified: Wed, 01 Aug 2012 14:01:30 GMT
[29460] ETag: "482dc0-4850b-4c634bb5dcf85"
[29460] Accept-Ranges: bytes
[29460] Content-Length: 296203
[29460] Content-Type: image/png
[29460] Connection: close
[29460] Proxy-Connection: close
[29460] Forwarding took 248161 us.
[29460] Finished.

-------------------------------------- Success
[29541] URL - http://tippspiel.spiegel.de/frontend/tippspiel/_master/img/css/bg_liga_h.png
[29541] Headers from client:
[29541] Accept: application/x-ms-application, image/jpeg, application/xaml+xml, image/gif, image/pjpeg, application/x-ms-xbap, application/vnd.ms-excel, application/vnd.ms-powerpoint, application/msword, */*
[29541] Accept-Language: de-DE,en-US;q=0.5
[29541] User-Agent: Mozilla/4.0 (compatible; MSIE 7.0; Windows NT 6.1; WOW64; Trident/5.0; .NET4.0C)
[29541] Accept-Encoding: gzip, deflate
[29541] Host: tippspiel.spiegel.de
[29541] Cookie: spVcData2=11-21%3B21-30; __utma=159392383.453791998.1351331618.1353014537.1353073350.12; __utmz=159392383.1351331618.1.1.utmcsr=(direct)|utmccn=(direct)|utmcmd=(none); spTopPosterHide=true; __utmc=159392383; PHPSESSID=eueb0n6iin7aldpsf56t1nqu35hhhlua
[29541] getting, parsing headers took 118 us.
[29541] Method = GET Protocol = HTTP/1.0
[29541] Headers sent to server:
[29541] GET /frontend/tippspiel/_master/img/css/bg_liga_h.png HTTP/1.0
[29541] Accept: application/x-ms-application, image/jpeg, application/xaml+xml, image/gif, image/pjpeg, application/x-ms-xbap, application/vnd.ms-excel, application/vnd.ms-powerpoint, application/msword, */*
[29541] Accept-Language: de-DE,en-US;q=0.5
[29541] User-Agent: Mozilla/4.0 (compatible; MSIE 7.0; Windows NT 6.1; WOW64; Trident/5.0; .NET4.0C)
[29541] Host: tippspiel.spiegel.de
[29541] Cookie: spVcData2=11-21%3B21-30; __utma=159392383.453791998.1351331618.1353014537.1353073350.12; __utmz=159392383.1351331618.1.1.utmcsr=(direct)|utmccn=(direct)|utmcmd=(none); spTopPosterHide=true; __utmc=159392383; PHPSESSID=eueb0n6iin7aldpsf56t1nqu35hhhlua
[29541] Accept-Encoding: gzip
[29541] Connection: close
[29541] Connecting, forwarding headers took 44674 us.
[29541] In Headers:
[29541] HTTP/1.1 200 OK
[29541] Date: Fri, 16 Nov 2012 14:31:26 GMT
[29541] Server: Apache/2.2.17 (Linux/SUSE)
[29541] Last-Modified: Thu, 15 Nov 2012 13:56:26 GMT
[29541] ETag: "4e285c-842-4ce890466d8cf"
[29541] Accept-Ranges: bytes
[29541] Content-Length: 2114
[29541] Connection: close
[29541] Content-Type: image/png
[29541] Image = 1, Chunked = 0
[29541] WillGZip = 1, Compress = 0, DoPreDecompress = 0
[29541] Trying to load the whole data into memory
[29541] Ok, whole data loaded into memory
[29541] Starting image decompression...
[29541] Image parms (non-palette) -- w: 180, h: 28, bpp: 4
[29541] Deciding image compression strategy...
[29541] Strategy defined. Continuing...
[29541] Attempting PNG compression...
[29541] Compression return codes -- JP2K:33 JPEG:33 PNG:0
[29541] Image modification/compression took 24135 us.
[29541] and returned 0.
[29541] Forwarding header and modified content.
[29541] Out Headers:
[29541] HTTP/1.1 200 OK
[29541] Date: Fri, 16 Nov 2012 14:31:26 GMT
[29541] Server: Apache/2.2.17 (Linux/SUSE)
[29541] Last-Modified: Thu, 15 Nov 2012 13:56:26 GMT
[29541] ETag: "4e285c-842-4ce890466d8cf"
[29541] Accept-Ranges: bytes
[29541] Content-Length: 1180
[29541] Content-Type: image/png
[29541] Connection: close
[29541] Proxy-Connection: close
[29541] Forwarding took 116 us.
[29541] Finished.

Keep-Alive interpretation

2011-02-28T12:28:56Z

Ziproxy 3.2.0 does not send the response to a request (http://cp32585.edgefcs.net/crossdomain.xml) on to the client. although it received it. The attachment contains a full capture of the tcp connections between client/proxy and proxy/server.

The server's response contains content-length field and a keep-alive. Ziproxy first sends a 200-response to the client, but not the response body (or not fully, the gziped data is incomplete). After 90 seconds it sends another response to the client (408 Request Timeout).

As far is I see, ziproxy should recognize the end of the whole response by the content-length header and close the connection to the server, regardless of the keep-alive header from the server.

timeout bug

2011-02-13T23:58:34Z

When it comes to data which is fully loaded into memory for processing
(pictures being the most usual case) Ziproxy is (wrongly) considering timeout
the whole elapsed time, instead of inactivity timeout.

The problem with this is when the picture takes too long to load (when link speed is terribly low, or when the picture is huge) it will timeout regardless the network activity.

TOSMarkAsDiffCT free problem

2010-02-10T15:32:12Z

When you enable option TOSMarkAsDiffCT some pages crashes.
I think that this patch resolve this problem.

can not be compiled against libpng 1.4.0

2010-02-03T15:20:34Z

ziproxy 2.7.9_BETA2 and 2.7.2 can not be compiled against current libpng version

For example: png_check_sig needs to be replaced with png_sig_cmp

switch filesize type from int

2009-12-08T07:22:06Z

For variables dealing with whole file/data size, switch from (signed) int to a compiling-time-defined type instead.

This is not a bug per se, but a characteristic of the code that may trigger buggy behavior.

Typically signed int are limited to ~2 GB of data (a 32bit var), what may bring problems in certain circumstances when proxying data bigger than that (logging and TOS based on file size will be affected, for example).
During compilation, something like ZP_T_XFERBYTES should be set to a type at least 64bit long.

silent fail if unable to bind

2009-12-02T05:30:45Z

There were reports that if Ziproxy is unable to bind to listen connections (like when the listening port is already being used by another daemon) it will silently fail.
Check that and, if confirmed, make Ziproxy display an error message.

Recent changes to bugs